This revision was automatically updated to reflect the committed changes.
Closed by commit rL330279: [HIP] Add driver input type for HIP (authored by
yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45489?vs=141851=142972#toc
yaxunl added a comment.
In https://reviews.llvm.org/D45489#1071177, @tra wrote:
> In https://reviews.llvm.org/D45489#1071044, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D45489#1070929, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D45489#1070470, @tra wrote:
> > >
> > > > I'm
tra added a comment.
In https://reviews.llvm.org/D45489#1071044, @yaxunl wrote:
> In https://reviews.llvm.org/D45489#1070929, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D45489#1070470, @tra wrote:
> >
> > > I'm getting confused about the order of the patches.
> > > The patch stack
yaxunl added a comment.
In https://reviews.llvm.org/D45489#1070929, @yaxunl wrote:
> In https://reviews.llvm.org/D45489#1070470, @tra wrote:
>
> > I'm getting confused about the order of the patches.
> > The patch stack phabricator displays in this patch is different compared
> > to the stack
yaxunl added a comment.
In https://reviews.llvm.org/D45489#1070470, @tra wrote:
> I'm getting confused about the order of the patches.
> The patch stack phabricator displays in this patch is different compared to
> the stack in https://reviews.llvm.org/D44984. Which one should I trust?
tra added a comment.
I'm getting confused about the order of the patches.
The patch stack phabricator displays in this patch is different compared to the
stack in https://reviews.llvm.org/D44984. Which one should I trust?
https://reviews.llvm.org/D45489
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D45489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl created this revision.
yaxunl added reviewers: tra, Hahnfeld.
This patch is split from https://reviews.llvm.org/D45212
https://reviews.llvm.org/D45489
Files:
include/clang/Driver/Types.def
lib/Driver/Driver.cpp
lib/Driver/Types.cpp
Index: lib/Driver/Types.cpp
