This revision was automatically updated to reflect the committed changes.
Closed by commit rL330244: [MinGW] Look for a cross sysroot relative to the
clang binary (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
mstorsjo added a comment.
In https://reviews.llvm.org/D45504#1070198, @rnk wrote:
> Sorry, I skipped over the message and looked at the code, which seems pretty
> straightforward.
>
> > Tests still are TBD, but posting this early to see if there's comments.
> > (How do I easily do a test that c
rnk added a comment.
Sorry, I skipped over the message and looked at the code, which seems pretty
straightforward.
> Tests still are TBD, but posting this early to see if there's comments. (How
> do I easily do a test that checks something relative to the clang binary,
> since I don't control
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D45504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
Ping
https://reviews.llvm.org/D45504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
Ping, any comments on the change itself, or tips on how to create a test for it?
https://reviews.llvm.org/D45504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mstorsjo updated this revision to Diff 141909.
mstorsjo added a comment.
Fixed the hardcoded triplet suffix, previously I erroneously had a "-gcc"
suffix there.
https://reviews.llvm.org/D45504
Files:
lib/Driver/ToolChains/MinGW.cpp
lib/Driver/ToolChains/MinGW.h
Index: lib/Driver/ToolChai
mstorsjo created this revision.
mstorsjo added reviewers: martell, rnk, compnerd, mati865, ismail, yaron.keren.
If found, prefer this over looking for a similar gcc later in the system path.
This implements what @martell suggested in https://reviews.llvm.org/D45152 in a
much neater way.
Tests s
