This revision was automatically updated to reflect the committed changes.
Closed by commit rL333510: [Sparc] Add floating-point register names (authored
by dcederman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
dcederman updated this revision to Diff 148351.
dcederman added a comment.
Removed the non-existing registers f33, f35, and so on. I also removed the dX
and qX aliases. After trying them they felt more confusing than helpful.
https://reviews.llvm.org/D47137
Files:
jrtc27 added inline comments.
Comment at: lib/Basic/Targets/Sparc.cpp:52
+
+// Double precision floating-point register
+{{"d0"}, "f0"}, {{"d1"}, "f2"}, {{"d2"}, "f4"}, {{"d3"}, "f6"},
jyknight wrote:
> AFAICT, gcc doesn't actually accept "d" and
jyknight added inline comments.
Comment at: lib/Basic/Targets/Sparc.cpp:32
+"f22", "f23", "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31",
"f32",
+"f33", "f34", "f35", "f36", "f37", "f38", "f39", "f40", "f41", "f42",
"f43",
+"f44", "f45", "f46", "f47",
dcederman updated this revision to Diff 148205.
dcederman added a comment.
Herald added a subscriber: eraman.
Added test cases, f32-f63, d0-d31, and q0-q15.
https://reviews.llvm.org/D47137
Files:
lib/Basic/Targets/Sparc.cpp
test/CodeGen/sparcv8-inline-asm.c
jrtc27 added a comment.
What about the V9 `dX` and `qX` aliases and `f32` to `f63`?
Repository:
rC Clang
https://reviews.llvm.org/D47137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jyknight added a comment.
Can you add a test that we support this?
clang/test/CodeGen/sparcv8-inline-asm.c would be a good place to add a test
case similar to that in clang/test/CodeGen/aarch64-inline-asm.c :
test_gcc_registers.
Repository:
rC Clang
https://reviews.llvm.org/D47137
dcederman created this revision.
dcederman added a reviewer: jyknight.
Herald added subscribers: cfe-commits, jrtc27, fedor.sergeev.
Repository:
rC Clang
https://reviews.llvm.org/D47137
Files:
lib/Basic/Targets/Sparc.cpp
Index: lib/Basic/Targets/Sparc.cpp
