[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334096: [Driver] Add flag --dependent-lib=... when enabling asan or ubsan on PS4. (authored by pgousseau, committed by ).

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

pgousseau updated this revision to Diff 150124. pgousseau added a comment. Updated patch with requested changes. https://reviews.llvm.org/D47375 Files: lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/PS4CPU.cpp lib/Driver/ToolChains/PS4CPU.h test/Driver/fsanitize.c

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

filcab added a comment. I have a minor nit + what Paul mentioned (missing a `-NOT` check). Otherwise LGTM. Comment at: lib/Driver/ToolChains/Clang.cpp:3690 - // Add runtime flag for PS4 when PGO or Coverage are enabled. - if (RawTriple.isPS4CPU()) + // Add runtime flag

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

probinson added a comment. LGTM with the indicated test tweak, but best if @filcab also takes a look. Comment at: lib/Driver/ToolChains/PS4CPU.cpp:87 +CmdArgs.push_back("--dependent-lib=libSceDbgAddressSanitizer_stub_weak.a"); + } +} Don't bother with

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

pgousseau created this revision. pgousseau added reviewers: rsmith, filcab, probinson, gbedwell. Herald added a subscriber: cfe-commits. NFC for targets other than PS4. Simplify users' workflow when enabling asan or ubsan and calling the linker separately. Repository: rC Clang