This revision was automatically updated to reflect the committed changes.
Closed by commit rC336539: [PCH] Add an option to not write comments into PCH
(authored by ibiryukov, committed by ).
Herald added a subscriber: omtcyfz.
Changed prior to commit:
https://reviews.llvm.org/D48942?vs=154115&
ilya-biryukov added a comment.
Not sure about two things:
- Using PreprocessorOptions for plumbing this setting. I'd rather put it into
FrontendOptions, but there seems to be no way to get those in the ASTWriter...
Happy to search for the alternatives
- Lack of tests. I'm not sure how to proper
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added a subscriber: ioeric.
Will be used in clangd, see the follow-up change.
Clangd does not use comments read from PCH to avoid crashes due to
changed contents of the file. However, reading them considerably s
