lebedev.ri abandoned this revision.
lebedev.ri added a comment.
In https://reviews.llvm.org/D49844#1177273, @rsmith wrote:
> What I requested was that either we make `CastExpr::isPartOfExplicitCast()`
> return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we
> move `isPartOfE
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
What I requested was that either we make `CastExpr::isPartOfExplicitCast()`
return `true` for `CastExpr`s that are not `ImplicitCastExpr`s, or that we move
`isPartOfExplicitCast` do
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
If @rsmith requested this, I'm fine with it then.
Repository:
rC Clang
https://reviews.llvm.org/D49844
___
cfe-commits mailing list
cf
lebedev.ri updated this revision to Diff 157484.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
Comment fine-tuning.
In https://reviews.llvm.org/D49844#1176639, @erichkeane wrote:
> I'm not sure that this logic requires a separate function. Since you've
> fixed the ge
erichkeane added a comment.
I'm not sure that this logic requires a separate function. Since you've fixed
the getIsPartOfExplicitCast logic correctly, it is pretty simple...
Comment at: include/clang/AST/Expr.h:2854
+ /// There are two global types of casts - implicit and ex
lebedev.ri created this revision.
lebedev.ri added reviewers: rsmith, erichkeane, rjmccall, aaron.ballman.
Herald added a subscriber: cfe-commits.
lebedev.ri added a dependency: D49838: [AST] Sink 'part of explicit cast' down
into ImplicitCastExpr.
This is mostly factored out of https://reviews.l
