[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

hubert.reinterpretcast added inline comments. Comment at: libcxx/trunk/include/istream:1223 +__state |= ios_base::badbit; return -1; } @ldionne, another dubious aspect of this patch is that it initializes `__r` to

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

w2yehia added inline comments. Herald added a project: All. Comment at: libcxx/trunk/include/istream:1222 { -this->setstate(ios_base::badbit); +__state |= ios_base::badbit; return -1; Hi @ldionne,

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne added a comment. In D49863#1452154 , @ldionne wrote: > In D49863#1452126 , @aprantl wrote: > > > It looks like this may have broken some LLDB data formatters: > >

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. In D49863#1452126 , @aprantl wrote: > It looks like this may have broken some LLDB data formatters: >

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

aprantl added a comment. It looks like this may have broken some LLDB data formatters: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22934/

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

mclow.lists accepted this revision. mclow.lists added a comment. I'm OK with this. I think, strictly speaking, that libc++ is following the standard, and everyone else is not - but what everyone else is doing makes sense. Comment at: libcxx/include/istream:365

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne added a comment. Herald added a subscriber: jkorous. I would like to merge this even though http://wg21.link/p1264 has not been voted into C++ yet, because this is arguably a bug and libc++ differs from other stdlibs in this regard. Once http://wg21.link/p1264 is merged into C++ in one

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

lichray accepted this revision. lichray added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: libcxx-commits. Comment at: libcxx/include/istream:365 __input_arithmetic(basic_istream<_CharT, _Traits>& __is, _Tp& __n) { -#ifndef

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne added a comment. This is a very tricky change since it touches all the input stream operations, both formatted and unformatted. However, I think it's an important change as it fixes extremely broken behavior. The paper I'm working on to fix this in the Standard is