This revision was automatically updated to reflect the committed changes.
Closed by commit rL348331: [clang-tidy/checks] Update objc-property-declaration
check to allow arbitrary… (authored by stephanemoore, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
stephanemoore updated this revision to Diff 176756.
stephanemoore added a comment.
Rebased changes and resolved merge conflicts.
Moved release notes update next to other release notes regarding updates to
existing checks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51832/new/
stephanemoore added a comment.
Chatted with Ben offline and he's okay with proceeding.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51832/new/
https://reviews.llvm.org/D51832
___
cfe-commits mailing
stephanemoore added a comment.
I believe that it should be safe to remove the `Acronyms` and
`IncludeDefaultAcronyms` options but if it's alright with you, I would prefer
to separate that into a followup change.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:28-31
stephanemoore updated this revision to Diff 172285.
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
Updated comments, release notes, and documentation to be consistent with the
implemented changes.
Repository:
rCTE Clang Tools Extra
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
This is fine, but please update the comments (and docs?) to make it clear that
we no longer enforce camelCase but allow aRBiTraRYcAsE now.
Comment at:
stephanemoore updated this revision to Diff 164583.
stephanemoore added a comment.
Sorted forward declared classes in `objc-property-declaration.m`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51832
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
stephanemoore updated this revision to Diff 164582.
stephanemoore added a comment.
Fix a couple issues:
• Forward declare `NSArray` in `objc-property-declaration.m`.
• Remove unnecessary lightweight generics declaration from `IDs` property in
`objc-property-declaration.m` to fix compilation
stephanemoore created this revision.
stephanemoore added reviewers: benhamilton, Wizard.
Herald added subscribers: cfe-commits, jfb.
§1 Description
This changes the objc-property-declaration check to allow arbitrary acronyms
and initialisms instead of using whitelisted acronyms. In Objective-C
