[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D51880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

JonasToth updated this revision to Diff 164876. JonasToth added a comment. rebase to master Repository: rC Clang https://reviews.llvm.org/D51880 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

JonasToth updated this revision to Diff 164873. JonasToth added a comment. - fix typos, include example in doc and adjust tests Repository: rC Clang https://reviews.llvm.org/D51880 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

JonasToth updated this revision to Diff 164863. JonasToth added a comment. - add isInstantiationDependent matcher as well - add unit tests for new matchers Repository: rC Clang https://reviews.llvm.org/D51880 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

aaron.ballman added a comment. In https://reviews.llvm.org/D51880#1230221, @JonasToth wrote: > In https://reviews.llvm.org/D51880#1229513, @aaron.ballman wrote: > > > Missing tests and changes to Registry.cpp for dynamic matchers. > > > > Also, do you want to add `isInstantiationDependent()` at t

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

JonasToth added a comment. In https://reviews.llvm.org/D51880#1229513, @aaron.ballman wrote: > Missing tests and changes to Registry.cpp for dynamic matchers. > > Also, do you want to add `isInstantiationDependent()` at the same time, given > the relationship with the other two matchers? Do yo

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

aaron.ballman added a comment. Missing tests and changes to Registry.cpp for dynamic matchers. Also, do you want to add `isInstantiationDependent()` at the same time, given the relationship with the other two matchers? Comment at: include/clang/ASTMatchers/ASTMatchers.h:777

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, klimek. Herald added a subscriber: cfe-commits. The new matchers can be used to check if an expression is type- or value-dependent in a templated context. These matchers are used in a clang-tidy check and generally