This revision was automatically updated to reflect the committed changes.
Closed by commit rC345497: [OpenCL] Fix serialization of OpenCLExtensionDecls
(authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-begin.cl:43
g(0); // expected-error {{no matching function for call to 'g'}}
-// expected-note@-26 {{candidate unavailable as it requires OpenCL
extension 'my_ext' to be disabled}}
-//
AlexeySachkov added inline comments.
Comment at: test/SemaOpenCL/extension-begin.cl:43
g(0); // expected-error {{no matching function for call to 'g'}}
-// expected-note@-26 {{candidate unavailable as it requires OpenCL
extension 'my_ext' to be disabled}}
-//
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Comment at: test/SemaOpenCL/extension-begin.cl:43
g(0); // expected-error {{no matching function for call to 'g'}}
-// expected-note@-26
AlexeySachkov updated this revision to Diff 170601.
AlexeySachkov added a comment.
Updated tests
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/SemaOpenCL/extension-begin.cl
test/SemaOpenCL/extension-begin.h
Index: test/SemaOpenCL/extension-begin.h
AlexeySachkov added inline comments.
Comment at: test/Headers/opencl-pragma-extension-begin.cl:1
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
Anastasia wrote:
> I think the tests in this folder are for standard includes only but you are
> testing custom include file
Anastasia accepted this revision.
Anastasia added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Headers/opencl-pragma-extension-begin.cl:1
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
I think the tests in this folder are for
AlexeySachkov added a comment.
@yaxunl could you please review this patch?
It fixes a bug in a feature implemented by you in:
commit c6fb598a301143e9d21156a012cc6ef669ff0188
Author: Yaxun Liu
AlexeySachkov updated this revision to Diff 169978.
AlexeySachkov added a comment.
Removed unnecessary empty line from test
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/Headers/opencl-pragma-extension-begin.cl
test/Headers/opencl-pragma-extension-begin.h
JDevlieghere added a comment.
The patch looks fine but since I don't know much about opencl I'll leave the
LGTM to someone that actually knows this code.
Comment at: test/Headers/opencl-pragma-extension-begin.h:1
+
+#pragma OPENCL EXTENSION cl_my_ext : begin
AlexeySachkov updated this revision to Diff 169851.
AlexeySachkov added a comment.
Added test
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/Headers/opencl-pragma-extension-begin.cl
test/Headers/opencl-pragma-extension-begin.h
Index:
JDevlieghere added a comment.
Can you add a test case please?
Repository:
rC Clang
https://reviews.llvm.org/D53200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexeySachkov created this revision.
AlexeySachkov added reviewers: Anastasia, yaxunl.
I recently discovered that adding the following code into `opencl-c.h` causes
failure of `test/Headers/opencl-c-header.cl`:
#pragma OPENCL EXTENSION cl_my_ext : begin
void cl_my_ext_foobarbaz();
#pragma
13 matches
Mail list logo
