This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344614: Remove possibility to change compile database path
at runtime (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53220?vs=169828=169833#toc
Repository:
sammccall accepted this revision.
sammccall added a comment.
Still LG!
Comment at: clangd/Protocol.h:422
+struct ClangdInitializationOptions : public ClangdConfigurationParamsChange {
+ llvm::Optional compilationDatabasePath;
+};
simark wrote:
> sammccall
simark updated this revision to Diff 169828.
simark marked 3 inline comments as done.
simark added a comment.
Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53220
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
clangd/Protocol.h
simark marked 7 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:433
reparseOpenedFiles();
}
sammccall wrote:
> sammccall wrote:
> > This isn't needed, the compilation database can only be set during
> >
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I think it'd be a good idea to separate out the on-initialization vs
dynamically-changing parameters more - I think they should probably be disjoint
in fact.
But we can
simark marked an inline comment as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.h:90
void reparseOpenedFiles();
+ void applyConfiguration(const ClangdInitializationOptions );
void applyConfiguration(const ClangdConfigurationParamsChange );
sammccall added a comment.
Thanks for cleaning this up!
Comment at: clangd/ClangdLSPServer.cpp:433
reparseOpenedFiles();
}
This isn't needed, the compilation database can only be set during
initialization.
Comment at:
simark created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
This patch removes the possibility to change the compilation database
path at runtime using the didChangeConfiguration request. Instead, it
is suggested to use the setting on
