This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346113: [analyzer] Restrict AnalyzerOptions interface
so that non-checker objects have… (authored by Szelethus, committed
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and
NoQ accepted this revision.
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it
Szelethus added a comment.
A polite ping :)
https://reviews.llvm.org/D53483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus marked 3 inline comments as done.
Szelethus added a comment.
Changing asserts to warnings will be delivered in a followup patch.
https://reviews.llvm.org/D53483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Szelethus updated this revision to Diff 171060.
Szelethus edited the summary of this revision.
Szelethus added a comment.
This diff has numerous changed to the last, but it's all "cosmetic", the actual
logic is untouched.
- Added documentation as @xazax.hun suggested
- Removed
Szelethus added a comment.
> (though I would also prefer if even checkers could pre-register their options
> somehow)
Good news, I've also successfully modified the tblgen file `Checkers.td` to be
able to register checker options (it took wy more effort and I thought it'd
take), so a list
george.karpenkov added a comment.
OK, so the overall direction makes sense: unregistered options are restricted
to checkers, and for others, an explicit getter must be maintained.
(though I would also prefer if even checkers could pre-register their options
somehow)
@NoQ does this make sense
xazax.hun added a comment.
Overall looks good if the community agrees with the directions. Some comments
inline.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:243
+ /// specified.
+ StringRef getStringOption(StringRef Name, StringRef DefaultVal);
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, rnkovacs, xazax.hun, MTC.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, szepet, whisperity.
Herald added a reviewer: teemperor.
One of the reasons why `AnalyzerOptions` is
16 matches
Mail list logo
