[PATCH] D53675: [WebAssembly] Lower select for vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rL346462: [WebAssembly] Lower select for vectors (authored by tlively, committed by ). Repository: rL LLVM https://reviews.llvm.org/D53675 Files:

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173120. tlively added a comment. - Update comment Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll test/CodeGen/WebAssembly/simd-vselect.ll

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added a comment. In https://reviews.llvm.org/D53675#1290660, @aheejin wrote: > I tried to add `ISD::SELECT` in the expansion list, like > > for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { > ... > } > > > And the code generation apparently works for current test

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 173119. tlively added a comment. - Use automatic expansion instead of patterns Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp test/CodeGen/WebAssembly/simd-select.ll

[PATCH] D53675: [WebAssembly] Lower select for vectors

aheejin added a comment. I tried to add `ISD::SELECT` in the expansion list, like for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { ... } And the code generation apparently works for current test `simd-select.ll`. I'm not sure if it's optimal though. Could you check again?

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172708. tlively added a dependency: D53630: [WebAssembly] Lower vselect. tlively added a comment. - Rebase onto SIMD reorganization Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172280. tlively added a comment. - Wrap comment to 80 chars. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172072. tlively added a comment. - Wrap comments at col 80. Restore proper revision contents. Repository: rL LLVM https://reviews.llvm.org/D53675 Files: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively added inline comments. Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587 +multiclass SIMDSelectPat { aheejin wrote: > Why do we need this pattern? Can't we also expand `SELECT` as we did for > `SELECT_CC` and `VSELECT`? It looks like the

[PATCH] D53675: [WebAssembly] Lower select for vectors

aheejin added a comment. The commit here looks like replaced with that of https://reviews.llvm.org/D53724. Repository: rC Clang https://reviews.llvm.org/D53675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53675: [WebAssembly] Lower select for vectors

tlively updated this revision to Diff 172060. tlively added a comment. Herald added a subscriber: cfe-commits. - Restore return types in names Repository: rC Clang https://reviews.llvm.org/D53675 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp