juliehockett abandoned this revision.
juliehockett added a comment.
After a lot of discussion, we'll do this migration internally. Thanks for your
comments!
https://reviews.llvm.org/D54168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
juliehockett updated this revision to Diff 172892.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:188
+
+ Suggests converting uses of ``fbl::move`` to
+ ``std::move``, and suggests inserting the header.
Please try to fill as much as possible to 80 characters.
juliehockett updated this revision to Diff 172889.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D54168
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp
juliehockett added a comment.
In https://reviews.llvm.org/D54168#1289128, @JonasToth wrote:
> I think this check is ok in the current form, but does it really need to be
> in upstream clang-tidy? You said its for migration only, so it is not
> valuable for you for a long time either?
So yes,
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp:61
+// Add in the header.
+if (auto IncludeFixit =
+Inserter->CreateIncludeInsertion(SM.getFileID(Start), "utility",
Please don't use auto
JonasToth added a comment.
I think this check is ok in the current form, but does it really need to be in
upstream clang-tidy? You said its for migration only, so it is not valuable for
you for a long time either?
Comment at:
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to convert fbl::move to std::move.
This check is part of a set of migration checks as we
