[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D54310#1296080, @arphaman wrote: > Apologies for not seeing this earlier. No worries, thanks for the input! >> The logic to do this was based on resource dir as an approximation of >> where the compiler is installed. This broke the to

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

arphaman added a comment. Apologies for not seeing this earlier. I agree with George, this behavior doesn't seem right to me. > The logic to do this was based on resource dir as an approximation of > where the compiler is installed. This broke the tools that read > 'compile_commands.json' and d

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

llvm-commits added a comment. - F7538987: msg-17782-346.txt Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D54310: Make clang-based tools find libc++ on MacOS

On Mon, Nov 12, 2018, 20:53 George Karpenkov via Phabricator < revi...@reviews.llvm.org wrote: > george.karpenkov added a comment. > > I don't quite understand the need for this patch. > If we are talking about a binary built from source, wouldn't it make more > sense to build libcxx from source a

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. In the future, for macOS-specific changes I think it would be better to wait for a sign-off from at least one maintainer who is an expert on Apple tools. Repository: rL LLVM https://reviews.llvm.org/D54310 ___ c

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. I suspect it broke http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/14090/console as well. Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. I don't quite understand the need for this patch. If we are talking about a binary built from source, wouldn't it make more sense to build libcxx from source as well? If libcxx is built from source in the same repo, clang-based tools do find it. Repository: r

Re: [PATCH] D54310: Make clang-based tools find libc++ on MacOS

Will take a look, thanks for the revert. On Mon, Nov 12, 2018 at 6:13 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > I reverted this because it broke the LLDB bots on GreenDragon: > http://green.lab.llvm.org/green/view/LLDB/ > > > Repos

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

JDevlieghere added a comment. I reverted this because it broke the LLDB bots on GreenDragon: http://green.lab.llvm.org/green/view/LLDB/ Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL346652: Make clang-based tools find libc++ on MacOS (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54310 Files: cfe/tr

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov updated this revision to Diff 173660. ilya-biryukov added a comment. - Added a test with a compiler path relative to the working dir Repository: rC Clang https://reviews.llvm.org/D54310 Files: include/clang/Lex/HeaderSearchOptions.h lib/Frontend/CreateInvocationFromCommandL

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D54310#1292924, @sammccall wrote: > If you know of a good reviewer for this, you may want a second opinion! This would definitely be nice, but I also don't know who'd be the proper person to review this. I'll take a pause until Monday,

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov updated this revision to Diff 173364. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Update the comment. Repository: rC Clang https://reviews.llvm.org/D54310 Files: include/clang/Lex/HeaderSearchOptions.h lib/Frontend/CreateInvocationFromCo

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is hacky, but solves an important problem. If you know of a good reviewer for this, you may want a second opinion! Comment at: include/clang/Lex/HeaderSearchOptio

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, arphaman. Herald added a reviewer: EricWF. Herald added subscribers: kadircet, christof, ioeric. When they read compiler args from compile_commands.json. This change allows to run clang-based tools, like clang-tidy or c