[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

This revision was automatically updated to reflect the committed changes. Closed by commit rC348384: [Basic] Cleanups in IdentifierInfo following the removal of PTH (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D54866?vs=175143=176843#toc

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno added a comment. Can this go in now that D54547 has been committed ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54866/new/ https://reviews.llvm.org/D54866 ___

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), erichkeane wrote: > riccibruno

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

erichkeane added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), riccibruno wrote: > erichkeane wrote: > > Instead of putting these in an

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), erichkeane wrote: > Instead of

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

erichkeane added a comment. This looks right to me. Note the PTH removal is still waiting approval. Comment at: include/clang/Basic/IdentifierTable.h:119 + IdentifierInfo() + : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false), Instead of

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno updated this revision to Diff 175143. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54866/new/ https://reviews.llvm.org/D54866 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp Index: lib/Basic/IdentifierTable.cpp

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno created this revision. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Conditional on D54547 : PTH-- Remove feature entirely- The `Entry` pointer in `IdentifierInfo` was only null for `IdentifierInfo`s created from a PTH.