This revision was automatically updated to reflect the committed changes.
Closed by commit rL348594: [CTU] Add DisplayCTUProgress analyzer switch
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
martong updated this revision to Diff 177204.
martong added a comment.
- Remove 'ANALYZE ' prefix from the log message
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
Files:
include/clang/CrossTU/CrossTranslationUnit.h
martong marked an inline comment as done.
martong added a comment.
> While Static Analyzer is the only client of CTU library at the moment, we
> might have more in the future. I would not use the phrase ANALYZE in the log
> message. Once this is resolved the rest looks good.
Ok, I removed the
xazax.hun accepted this revision.
xazax.hun added a comment.
While Static Analyzer is the only client of CTU library at the moment, we might
have more in the future. I would not use the phrase `ANALYZE` in the log
message. Once this is resolved the rest looks good.
Repository:
rC Clang
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM! :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
martong added a comment.
> should be an -analyzer-config option.
Ok, just changed it to be.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
___
cfe-commits mailing list
martong updated this revision to Diff 176653.
martong added a comment.
- Use clang_analyze_cc1
- Change to be an analyzer config option
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
Files:
xazax.hun added a comment.
Having an analyzer config option makes sense.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
___
cfe-commits mailing list
Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.
The code not directly related to adding the actual flag looks great, but this
still should be an `-analyzer-config` option.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
Szelethus added inline comments.
Comment at: test/Analysis/ctu-main.cpp:6
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze
-analyzer-checker=core,debug.ExprInspection -analyzer-config
experimental-enable-naive-ctu-analysis=true -analyzer-config
martong updated this revision to Diff 176590.
martong marked an inline comment as done.
martong added a comment.
- Break long RUN line
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
Files:
martong added inline comments.
Comment at: test/Analysis/ctu-main.cpp:6
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze
-analyzer-checker=core,debug.ExprInspection -analyzer-config
experimental-enable-naive-ctu-analysis=true -analyzer-config
martong updated this revision to Diff 176582.
martong added a comment.
- Change the CTU progress message in the test too
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
Files:
martong updated this revision to Diff 176581.
martong marked 4 inline comments as done.
martong added a comment.
- Rename AnalyzerDisplayCtuProgress to Opts.AnalyzerDisplayCTUProgress
- Change the CTU progress message
Repository:
rC Clang
CHANGES SINCE LAST ACTION
martong added a comment.
> Also, almost everywhere CTU is capitalized, so I guess it should be in the
> field name too.
Ok, I renamed it to have CTU all capitalized.
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:239
+ if (DisplayCTUProgress) {
+llvm::errs()
Szelethus added a comment.
Also, `AnalyzerOptions.def` was recently clan-formatted, feel free to run it
again after the changes you make in it.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
a_sidorin added a comment.
Hi Gabor,
In addition to Umann remarks, there is a small comment inline.
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:239
+ if (DisplayCTUProgress) {
+llvm::errs() << "ANALYZE (CTU loaded AST for source file): "
+
Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.
The idea is great!
I think this should rather be an -analyzer-config flag, since the actual
analysis changes with a new output (refer to `AnalyzerOption`'s doxygen
comments).
martong created this revision.
martong added reviewers: xazax.hun, Szelethus, a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity.
Herald added a reviewer: george.karpenkov.
With a new
19 matches
Mail list logo
