alexfh added inline comments.
Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:25
#include "StrCatAppendCheck.h"
Please upload the patch with full context. See
https://llvm.org/docs/Phabricator.html
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Could you send each check in a separate patch, please? This makes the review
much more straightforward and I'm sure it will be faster too.
Repository:
rCTE Clang Tools Extra
CHAN
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-anonymous-enclosed-aliases.rst:20
+
+ } // foo
Are there guidelines?
Comment at: docs/clang-tidy/checks/abseil-qualified-aliases.rst:22
+
+See https://abseil.io/ti
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:31
+
+
+void AnonymousEnclosedAliasesCheck::check(const MatchFinder::MatchResult
&Result) {
Please remove unnecessary empty line.
Comment at:
Naysh created this revision.
Naysh added reviewers: EricWF, JonasToth.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
This patch adds four new, small checks corresponding to the guidelines in
https://abseil.io/tips/119.
The checks are:
- Alias Free Headers: makes sure header files do
