[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

2018-12-16 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL349327: [analyzer] MoveChecker: Add an option to suppress warnings on locals. (authored by dergachev, committed by ). Hera

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

2018-12-16 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:188-195 + void setAggressiveness(StringRef Str) { +Aggressiveness = +llvm::StringSwitch(Str) +.Case("KnownsOnly", AK_KnownsOnly) +.Case("KnownsAndLocals",

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

2018-12-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:188-195 + void setAggressiveness(StringRef Str) { +Aggressiveness = +llvm::StringSwitch(Str) +.Case("KnownsOnly", AK_KnownsOnly) +.Case("KnownsAndLocals", AK_Kn

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

2018-12-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:188-195 + void setAggressiveness(StringRef Str) { +Aggressiveness = +llvm::StringSwitch(Str) +.Case("KnownsOnly", AK_KnownsOnly) +.Case("KnownsAndLocals", AK_Kn

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

2018-12-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:29 namespace { - struct RegionState { Somewhat unrelated, but the size of this anonymous namespace is far too great. Comment at: lib/StaticAnalyzer/Check