[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350882: [sanitizer_common] Define __sanitizer_FILE on NetBSD (authored by mgorny, committed by ). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

eugenis added a comment. In D56109#1341967 , @mgorny wrote: > We've been discussing this, and I think we're doing this the wrong way. Could > you help me a little understand this? > > In particular, what is the purpose of unpoisoning file? Is it in order

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a comment. In D56109#1344521 , @vitalybuka wrote: > LGTM Thanks! Any feedback regarding the raised comments in https://reviews.llvm.org/D56109#1341967 and https://reviews.llvm.org/D56109#1342059 ? CHANGES SINCE LAST ACTION

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

vitalybuka added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179681. mgorny added a comment. Implemented `fileno_unlocked` as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/tsan/rtl/tsan_interceptors.cc:45 #define dirfd(dirp) (*(int *)(dirp)) #define fileno_unlocked fileno We might want to go for emulating `_unlocked`: ``` #define fileno_unlocked(p) \ 488

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a subscriber: dvyukov. krytarowski added a comment. If we understand it correctly, unpoision FILE would be only for inlined routines accessing FILE buffer(s) directly. On NetBSD we enforce _REENTRANT for all sanitizers in order to support only _REENTRANT variations of calls

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added reviewers: eugenis, kcc. mgorny added a comment. We've been discussing this, and I think we're doing this the wrong way. Could you help me a little understand this? In particular, what is the purpose of unpoisoning file? Is it in order to account for stdio functions being

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179641. mgorny marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698 +#if SANITIZER_NETBSD + if (fp->_bf._base) +COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base, krytarowski wrote:

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698 +#if SANITIZER_NETBSD + if (fp->_bf._base) +COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base, maybe `if (fp->_bf._base && fp->_bf._size)` CHANGES

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a comment. As a subtask please add missing calls to `unpoison_file` in interceptors (in sanitizer_common_interceptors.inc) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179570. mgorny marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:2249 +CHECK_SIZE_AND_OFFSET(FILE, _offset); +CHECK_SIZE_AND_OFFSET(FILE, _flags); + krytarowski wrote: > Duplicate with L2231 Fixed. CHANGES SINCE LAST ACTION

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:2249 +CHECK_SIZE_AND_OFFSET(FILE, _offset); +CHECK_SIZE_AND_OFFSET(FILE, _flags); + Duplicate with L2231 Repository: rCRT Compiler Runtime CHANGES SINCE

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc