[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL350232: [sanitizer_common] Implement popen, popenve, pclose interceptors (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do {

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny updated this revision to Diff 179842. mgorny added a comment. Updated to use `COMMON_INTERCEPTOR_FILE_OPEN` with `nullptr` argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/ https://reviews.llvm.org/D56157 Files:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked 4 inline comments as done. mgorny added a comment. The tests were submitted earlier as D56153 . I'll implement the remaining suggestions. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

dvyukov added inline comments. Comment at: lib/tsan/rtl/tsan_interceptors.cc:2259 +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + if (file) { \ krytarowski wrote: > dvyukov wrote: > > An alternative would be to pass NULL

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

krytarowski added inline comments. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do { \

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

dvyukov added a comment. This needs some tests, at least to exercise interceptors code once. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do {

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

krytarowski added a subscriber: dvyukov. krytarowski added a comment. Looks good to me, but it would be nice to have opinion of @vitalybuka and/or @dvyukov (TSan). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Implement the interceptors for popen(), pclose() and popenve() functions. The first two are POSIX, the third one is specific to NetBSD. popen() spawns a