[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 188213. dgoldman added a comment. - Remove (class extension) as it's no longer needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

arphaman added a comment. Please add a test that covers the '(class extension)' output as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. ping, looking to get this in to fix a clangd assertion failure Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1379342 , @arphaman wrote: > Do you know if this have an effect on the output of completion results or > other tooling-based output? > > A couple of requests: > > - This behavior should be controlled by a printing

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 185341. dgoldman added a comment. Herald added a project: clang. - Output class scope for ObjCPropertyDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. Do you know if this have an effect on the output of completion results or other tooling-based output? A couple of requests: - This behavior should be controlled by a printing

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1367450 , @sammccall wrote: > This is definitely an improvement, though I don't know if it's *right*. > @akyrtzi, thoughts? Yeah, I'm not sure what the desired behavior is. When writing up the test I noticed there

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

sammccall added a comment. This is definitely an improvement, though I don't know if it's *right*. @akyrtzi, thoughts? Comment at: unittests/AST/NamedDeclPrinterTest.cpp:206 +"property", +"(class extension)::property")); +} One concern is that

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 182971. dgoldman added a comment. Herald added a subscriber: jfb. - Add test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman created this revision. Herald added a subscriber: cfe-commits. Since class extensions do not have a name, (class extension) is used instead. Repository: rC Clang https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp