[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. Herald added a subscriber: dexonsmith. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D56924: Special case ObjCPropertyDecl for printing

arphaman added a comment. Sorry, I missed the pings. It LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman updated this revision to Diff 193769. dgoldman added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedDeclPrinterTest.cpp Index: unittests/AST/Nam

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman closed this revision. dgoldman added a comment. Closed via rL357720 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commit

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D56924: Special case ObjCPropertyDecl for printing

gribozavr added inline comments. Comment at: lib/AST/Decl.cpp:1543 +Ctx = ID; + } Like you said in a private conversation, yes, support for `ObjCIvarDecl` also seems necessary. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dexonsmith added subscribers: jkorous, benlangmuir. dexonsmith added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} gribozavr wrote: > I don't think that `Obj::property` is the preferred syntax.

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} dexonsmith wrote: > gribozavr wrote: > > I don't think that `Obj::property` is the preferred syntax. `Obj.property`? > > I'd want a

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. In D56924#1407836 , @arphaman wrote: > Please add a test that covers the '(class extension)' output as well. Removed the `(class extension)` output as the property getter if statement should now handle this. Repository: rC

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. friendly ping, think this is good to go now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h