[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361552: [analyzer] Add a new frontend flag to display all checker options (authored by Szelethus, committed by ). Herald a

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. In D57858#1502052 , @NoQ wrote: > In D57858#1501065 , @dkrupp wrote: > > > These are the alpha checkers that we are testing in Ericsson: > > > Hmm, if you don't mind i'll take this to cfe-

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. http://lists.llvm.org/pipermail/cfe-dev/2019-May/062298.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. In D57858#1501065 , @dkrupp wrote: > These are the alpha checkers that we are testing in Ericsson: Hmm, if you don't mind i'll take this to cfe-dev, as it's an interesting topic :) CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. In D57858#1500635 , @NoQ wrote: > In D57858#146 , @dkrupp wrote: > > > Some alpha checkers are considerably more mature than others and are quite > > usable. In our experience, there are

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. In D57858#1500635 , @NoQ wrote: > In D57858#146 , @dkrupp wrote: > > > Some alpha checkers are considerably more mature than others and are quite > > usable. In our experience, there

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. In D57858#146 , @dkrupp wrote: > Some alpha checkers are considerably more mature than others and are quite > usable. In our experience, there are some users who are keen to run these > checkers on their code and report back any

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. In D57858#1499414 , @Szelethus wrote: > In D57858#1498640 , @NoQ wrote: > > > So, like, the global picture is as follows. In our case the Driver (i.e., > > --analyze) is not much more user f

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a subscriber: o.gyorgy. Szelethus added a comment. In D57858#1498640 , @NoQ wrote: > So, like, the global picture is as follows. In our case the Driver (i.e., > --analyze) is not much more user facing than frontend flags. It's still > fai

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. In D57858#1498651 , @NoQ wrote: > Also, for CodeChecker purposes wouldn't you rather have a machine-readable > dump? My main purpose was readability in the terminal, but I will need to think about that eventually. The current

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus updated this revision to Diff 199188. Szelethus added a comment. - Make the educated observation that the code for formatted output is duplicated for `-analyzer-checker-help`, `-analyzer-config-help` and this patch, reuse it via the new static function `AnalyzerOptions::printFormatted

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. Also, for CodeChecker purposes wouldn't you rather have a machine-readable dump? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. Let's land this together with @Szelethus's proposed solution of hiding hidden options (like checkers in D60925 ). I'm still in favor of hiding alpha checkers (as they are for development only, much like debug flags; i'd recommend hiding them

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus requested review of this revision. Szelethus added a comment. Similarly to D60925 , I plan to make a patch that will hide most the implementation options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

whisperity added a comment. @dcoughlin How would removing the `USAGE` part of the dump and keeping only the list of options and their formatted help sound? That way, this option will not invite the user to directly call the analyzer. In D57858#1432714 ,

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. @dcoughlin I don't necessarily agree with you. Let me explain why we think this feature is important. We should give the users the possibility to list all possibly configurable checker options and their meaning. Many of these options should be possible to be set by the e

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. This patch isn't intended for end users, which is why `-analyzer-checker-option-help` is a frontend flag -- besides, some of the plain frontend flags aren't either. It is purely for development purposes, though exposing an end user friendly subset of these through a d

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dcoughlin requested changes to this revision. dcoughlin added a comment. This revision now requires changes to proceed. I'm pretty worried about exposing this flag to end users. - Almost none of the options you've listed are user facing. Many represent options intended for use by static analyzer

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus updated this revision to Diff 190997. Szelethus added a comment. Add a test case for then checker plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 Files: include/clang/Driver/CC1Options.td include/clang/StaticAnalyzer/Core/A

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus updated this revision to Diff 190625. Szelethus edited the summary of this revision. Szelethus added a comment. Herald added subscribers: Charusso, jdoerfert. Also, don't forget package options :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.o

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this is awesome! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls, whisperity, javed.absar. Herald added a project: cla