[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL356722: [AArch64] Split the neon.addp intrinsic into integer and fp variants. (authored by aemerson, committed by ). Changed prior to commit: https://reviews.llvm.org/D59655?vs=191774&id=191792#toc Rep

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 ___

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191774. aemerson added a comment. Simplify logic and don't try to upgrade if IR is invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma added a comment. The IR at this Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; aemerson wrote: >

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; ---

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; This code is weird... you're

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson added a comment. I've put up a langref change as a separate review: D59657 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 _

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191745. aemerson added a comment. Minor test tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson created this revision. aemerson added reviewers: paquette, eli.friedman, t.p.northover. aemerson added projects: LLVM, clang. Herald added subscribers: Petar.Avramovic, hiraditya, kristof.beyls, javed.absar. This is the result of discussions on the list about how to deal with intrinsics