[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

stephanemoore added a comment. Looks good to me. Comment at: cfe/trunk/lib/Format/Format.cpp:881 +// "Regroup" doesn't work well for ObjC yet (main header heuristic, +// relationship between ObjC standard library headers and other heades, +// #imports, etc.) ---

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Please don't land changes with open discussion. Objective-C++ basically is C++ code. I don't think it makes sense to make a distinction here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

This revision was automatically updated to reflect the committed changes. Closed by commit rL357695: [clang-format] Preserve include blocks in ObjC Google style (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir updated this revision to Diff 193699. krasimir added a comment. - Add a note about intent Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp I

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir marked an inline comment as done. krasimir added a comment. In D60263#1454812 , @thakis wrote: > Why would we want this to be different in Obj-C and C++? Only the C++ Style Guide had been updated. Practically, clang-format would need to be updat

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Why would we want this to be different in Obj-C and C++? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

Why would we want this to be different in Obj-C and C++? On Thu, Apr 4, 2019 at 9:34 AM Krasimir Georgiev via Phabricator via cfe-commits wrote: > krasimir marked 2 inline comments as done. > krasimir added inline comments. > > > > Comment at: lib/Format/Format.cpp:787 >Goog

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir marked 2 inline comments as done. krasimir added inline comments. Comment at: lib/Format/Format.cpp:787 GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$"; GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; GoogleSt

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

ioeric added inline comments. Comment at: lib/Format/Format.cpp:787 GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$"; GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; GoogleStyle.IndentCaseLabels = true;

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir created this revision. krasimir added a reviewer: ioeric. Herald added a project: clang. Herald added a subscriber: cfe-commits. r357567 started to regroup include block for Google style; it was meant to apply only for C++. This patch reverts this for ObjC. Repository: rC Clang https