[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. I think this ultimately needs to be split up into smaller patches. A bunch of these things can be landed independently. Here is my first cut at things to split out, each one

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan added a comment. In D62225#1519394 , @efriedma wrote: > Are the behavior differences between the newpm alwaysinliner and the oldpm > alwaysinliner intentional? Specifically, the differences in pass remarks, > and the differences in the

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

efriedma added a comment. Are the behavior differences between the newpm alwaysinliner and the oldpm alwaysinliner intentional? Specifically, the differences in pass remarks, and the differences in the treatment of the alwaysinline attribute seem suspect. (I'm not that interested in the

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan updated this revision to Diff 201089. leonardchan edited the summary of this revision. Herald added a subscriber: aprantl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62225/new/ https://reviews.llvm.org/D62225 Files:

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan updated this revision to Diff 200860. leonardchan marked an inline comment as done. leonardchan edited the summary of this revision. Herald added subscribers: llvm-commits, dexonsmith, steven_wu, kbarton, hiraditya, eraman, nemanjai, mehdi_amini. Herald added a project: LLVM.

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan marked 4 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since according to the legacy PM logic for + //

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

echristo added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since according to the legacy PM logic for + // enabling

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: kristof.beyls, javed.absar. This is a patch that should go on top of D58375 which