[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

This revision was automatically updated to reflect the committed changes. Closed by commit rL366417: [OpenCL][PR42033] Fix addr space deduction with template parameters (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 ___ cfe-commits mailing list

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 210277. Anastasia added a comment. Fixed typo in the comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 Files: lib/Sema/SemaDecl.cpp lib/Sema/SemaType.cpp lib/Sema/TreeTransform.h

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added a comment. Minor comment then LGTM Comment at: lib/Sema/SemaType.cpp:7418 + // Expect for pointer or reference types because the addr space in + // template argument can only belong to a pointee. + (T->isDependentType() && !T->isPointerType() &&

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1586640 , @rjmccall wrote: > In D62584#1585091 , @Anastasia wrote: > > > In D62584#1583340 , @rjmccall > > wrote: > > > > > Oh, yes, it

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added a comment. In D62584#1585091 , @Anastasia wrote: > In D62584#1583340 , @rjmccall wrote: > > > Oh, yes, it definitely can't be done to class types. I suppose we should > > just forget about it. > >

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1583340 , @rjmccall wrote: > Oh, yes, it definitely can't be done to class types. I suppose we should > just forget about it. Ok, regarding address space qualifiers in template instantiation - is it still ok that

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added a comment. Oh, yes, it definitely can't be done to class types. I suppose we should just forget about it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 ___ cfe-commits mailing

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(),

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(),

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 207562. Anastasia added a comment. - Removed diagnostic for address space in return type in tree transforms CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 Files: lib/Sema/SemaDecl.cpp

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(),

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1522438 , @rjmccall wrote: > I think the right approach here is probably to make sure you're applying > deduction during instantiation as well. I agree I think we might need to extend the template instantiation

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 202753. Anastasia retitled this revision from "[OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types" to "[OpenCL][PR42033] Deducing addr space with template parameter types". Anastasia edited the summary of this