[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't this do the > same thing? Diego, why

[PATCH] D63180: [clang-doc] Adds HTML generator

jakehehrlich added a comment. I'm getting confused in all the different patches. I reviewed the HTML generator one like yesterday and was awaiting changes. Doesn't this do the same thing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63180/new/ https://reviews.llvm.org/D63180

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:106-107 + + std::string Buffer; + llvm::raw_string_ostream Members(Buffer); + if (!I.Members.empty())

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran marked 12 inline comments as done. DiegoAstiazaran added a comment. A couple of comments that were related to the function writeDescription() were marked as done since most of that function was deleted. Rendering of the other kinds of CommentInfos will be handled later.

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran updated this revision to Diff 206502. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Removed rendering of some CommentInfo kinds to reduce review load. Removed all , , and tags; they are not

[PATCH] D63180: [clang-doc] Adds HTML generator

jakehehrlich added a comment. I got to the 'genHTML' functions and I decided that this general approach is not great. What if we have a baby internal representation of an HTML tree, generate instances of that, and then implement a render method on that (preferably one that handles indentation

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:87 +std::string CloseTag = I.SelfClosing ? "/>" : ">"; +writeLine("<" + I.Name + Attrs.str() + CloseTag, OS); + } else if (I.Kind == "HTMLEndTagComment") { You

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. Implement a simple HMTL generator based on the existing Markdown generator.