[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

This revision was automatically updated to reflect the committed changes. Closed by commit rL367982: [Driver] Introduce -stdlib++-isystem (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a reviewer: rnk. smeenai added a subscriber: rnk. smeenai added a comment. Adding @rnk as someone familiar with the driver/frontend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This looks fine to me, but I'd like to have someone else familiar with the Driver/Frontend design sign off too. The implementation is trivial but I'd

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai marked an inline comment as done. smeenai added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args,

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args, CmdArgs); +}); So,

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1576902 , @ldionne wrote: > Background question: I'm familiar with the behavior on Darwin, where we > prefer C++ headers in the toolchain (alongside the driver), however do other > platforms behave the same? I thought

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne added a comment. Background question: I'm familiar with the behavior on Darwin, where we prefer C++ headers in the toolchain (alongside the driver), however do other platforms behave the same? I thought this was something specific to Darwin. Repository: rG LLVM Github Monorepo

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1567028 , @danalbert wrote: > > For example, when we're building against the Android NDK, we might want to > > use the NDK's C++ headers (which have a custom inline namespace) even if we > > have C++ headers installed

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

danalbert added a comment. > For example, when we're building against the Android NDK, we might want to > use the NDK's C++ headers (which have a custom inline namespace) even if we > have C++ headers installed next to the driver. Since NDK r19 the NDK libc++ headers are already installed

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rsmith, zer0. Herald added a subscriber: srhines. Herald added a project: clang. There are times when we wish to explicitly control the C++ standard library search paths used by the driver. For example, when we're building