[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL367839: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:26 + VisitedImplicitInitializer = true; +Match("initializer",

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213323. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Herald added a subscriber: mgorny. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:29 +if (!Init->isWritten()) + VisitedImplicitInitializer = true; +Match("initializer",

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

ilya-biryukov added a comment. LGTM from my side, a few optional NITs. Feel free to land as soon as @hokein stamps. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:16 + +// Check to ensure that CXXCtorInitializer is not visited when

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp:2 +//===- unittest/Tooling/RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp +//-===// +// we should make them one line even it exceeds 80

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213294. jvikstrom added a comment. Call the base Traverse.. function in the visitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65735/new/ https://reviews.llvm.org/D65735 Files:

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom updated this revision to Diff 213291. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Moved test to its own test file (also addressed comments about the test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

ilya-biryukov added a comment. The fix looks good. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:17 // syntactic and semantic form. class InitListExprPreOrderVisitor : public ExpectedLocationVisitor { Could you

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

hokein added a comment. I think this is a reasonable fix, just a few comments on the test. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:26 + bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { +if

[PATCH] D65735: [AST] Fix RecursiveASTVisitor visiting implicit constructor initializers.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. RecursiveASTVisitor was visiting implcit constructor initializers. This caused semantic highlighting in clangd to emit error logs.