[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623939 , @hfinkel wrote: > In D65835#1623903 , @ABataev wrote: > > > In D65835#1623883 , @hfinkel wrote: > > > > > In D65835#1623814

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623903 , @ABataev wrote: > In D65835#1623883 , @hfinkel wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623858 , @ABataev wrote: > In D65835#1623854 , @jdenny wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623854 , @jdenny wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623772 , @ABataev wrote: > In D65835#1623756 , @kkwli0 wrote: > > > In D65835#1622042 , @ABataev wrote: > > > > > > I want to be sure

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623756 , @kkwli0 wrote: > In D65835#1622042 , @ABataev wrote: > > > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > > is_device_ptr with the

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1622042 , @ABataev wrote: > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > is_device_ptr with the private clauses? > > Yes, since it is allowed by the standard. Umm ... I probably

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > is_device_ptr with the private clauses? Yes, since it is allowed by the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1621202 , @ABataev wrote: > >> See 2.19.7 Data-Mapping Attribute Rules, Clauses, and Directives > > > > I looked again. I'm still not finding any text in that section that > > implies is_device_ptr follows the same

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1621168 , @jdenny wrote: > In D65835#1619560 , @ABataev wrote: > > > In D65835#1619549 , @jdenny wrote: > > > > > In D65835#1619526

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny marked 2 inline comments as done. jdenny added a comment. In D65835#1619560 , @ABataev wrote: > In D65835#1619549 , @jdenny wrote: > > > In D65835#1619526 , @ABataev

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1619549 , @jdenny wrote: > In D65835#1619526 , @ABataev wrote: > > > > Maybe, but I haven't found any statement in either version that states > > > that map restrictions apply to

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1619526 , @ABataev wrote: > > Maybe, but I haven't found any statement in either version that states that > > map restrictions apply to is_device_ptr. > > `is_device_ptr` is a kind of mapping clause. I assume we can

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > I should have reported that the current implementation isn't complete for > OpenMP 4.5. For example, on target teams, reduction(+:x) map(x) is an error > but not map(x) reduction(+:x). So there are bugs to fix, and maybe this will > evolve into multiple patches, but

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > Maybe, but I haven't found any statement in either version that states that > map restrictions apply to is_device_ptr. `is_device_ptr` is a kind of mapping clause. I assume we can extend the restrictions for `map` clause to this clause too. > Another question is

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny marked an inline comment as done. jdenny added a comment. In D65835#1618865 , @ABataev wrote: > `is_device_ptr` can be considered as a kind of mapping clause (see 2.19.7 > Data-Mapping Attribute Rules, Clauses, and Directives), so, I assume,

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. `is_device_ptr` can be considered as a kind of mapping clause (see 2.19.7 Data-Mapping Attribute Rules, Clauses, and Directives), so, I assume, clang correct here in terms of OpenMP 4.5. Thus, I would not call this a "fix", this is just a new feature from OpenMP 5.0.

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. For `map`, the following restriction changed in OpenMP 5.0: - OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item cannot appear in