[PATCH] D66199: [docs] loop pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rG52bfa73af841: [docs] loop pragmas: options implying transformations (authored by SjoerdMeijer). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. Sure, will do, thanks again for taking a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66199: [docs] loop pragmas

hsaito accepted this revision. hsaito added a comment. This revision is now accepted and ready to land. LGTM. Please wait for a few days in case others have more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer updated this revision to Diff 224421. SjoerdMeijer added a comment. Thanks! Typo fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/ https://reviews.llvm.org/D66199 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D66199: [docs] loop pragmas

hsaito added inline comments. Comment at: docs/LanguageExtensions.rst:3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set transformation options (e.g. +``vectorize_width``, ``unroll_count``). Pragmas

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. I have commit all my pragma patches, so now back to the last bit, this doc update. This doc change should now reflect our implementation. Are we happy for this to go in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66199/new/

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. Many thanks for your clarification! > What we were discussing was that these settings would remove 0) from the > candidate list as well. Yep, that's crystal clear now. And my expectation would indeed be that this would be the case. CHANGES SINCE LAST ACTION

[PATCH] D66199: [docs] loop pragmas

Meinersbur added inline comments. Comment at: docs/LanguageExtensions.rst:3068-3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set transformation options (e.g. +``vectorize_width``, ``unroll_count``).

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added a comment. > Since this is user documentation, we should only add it here once it is true. Yep, good point, I also wanted to capture our discussions on the list. But yes, let's hold this back until we're ready with the pragmas.

[PATCH] D66199: [docs] loop pragmas

Meinersbur added a comment. Since this is user documentation, we should only add it here once it is true. Comment at: docs/LanguageExtensions.rst:3068-3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: fhahn, Meinersbur, dorit, hsaito. Following our discussion on the cfe dev list (http://lists.llvm.org/pipermail/cfe-dev/2019-August/063054.html), I have added a paragraph that is explicit about transformation options implying the