[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

MaskRay added inline comments. Comment at: cfe/trunk/include/clang/Index/IndexingAction.h:58 +const IndexingOptions &Opts, std::shared_ptr PP, +std::function ShouldSkipFunctionBody); + I know ShouldSkipFunctionBody is important for multi-threaded indexing

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

This revision was automatically updated to reflect the committed changes. Closed by commit rL370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, gribozavr wrote: > jkorous wrote: > > Why not use default argument instead of overload

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, jkorous wrote: > Why not use default argument instead of overloading? Writing a whol

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added a comment. Otherwise LGTM. Thanks for refactoring this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66879/new/ https://reviews.llvm.org/D66879 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, Why not use default argument instead of overloading? Repository: rG LLVM Github Mo

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. gribozavr added reviewers: ilya-biryukov, jkorous. Herald added a subscriber: dexonsmith. gribozavr added a parent revision: D66878: [Index] Stopped wrapping Frontend