[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371451: [analyzer] NFC: Simplify bug report equivalence classes to not be ilists. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:569 SmallVectorImpl ) { -return &*eqClass.begin(); +return eqClass.getReports().begin()->get();

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr accepted this revision. gribozavr added a comment. Still LGTM, just some nitpicks to replace iterator usage with index-based accesses (which I believe is simpler). Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:569

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ updated this revision to Diff 219011. NoQ added a comment. Fxd, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67024/new/ https://reviews.llvm.org/D67024 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

Szelethus accepted this revision. Szelethus added a comment. Other then the things @gribozavr mentioned, LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:458 +public: + typedef llvm::SmallVector, 4> ReportList; + using iterator =

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using const_iterator = ReportList::const_iterator; + gribozavr wrote: > gribozavr wrote: > > I don't

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using const_iterator = ReportList::const_iterator; + gribozavr wrote: > I don't think we intend users

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks for the simplification! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:460 + using iterator = ReportList::iterator; + using

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, dylanmckay. Herald added a project: clang. They are said to be more