[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. Re-applied with test fix in https://reviews.llvm.org/rG4fccd383d571865321b4723b81c3042d2c15fd80 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Re-applied with typo fix in rGdf876a026981 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. Reverted in 3de7cc9fc01c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. The test fails on Windows: http://45.33.8.238/win/2576/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___ cfe-commits

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d7bbfa0043: [RISCV] Support mutilib in baremetal environment (authored by khchen, committed by Zakk Chen zakk.c...@sifive.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 229966. khchen added a comment. rebase and fix failed testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Do rebase this patch now that D69383 has landed, and check that it is still working correctly. If so, you can land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 229507. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Requires the changes in D69383 to land before this can. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1544 + StringRef ABIName =

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 227606. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. I have just updated D69383 . It now defaults to `rv{XLEN}imac` on ELF, rather than `rv{XLEN}gc`. This is to help this multilib issue. In the future, we want to implement MULTILIB_REUSE properly. Hopefully before Clang 10.0.0 is

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. In D67508#1720228 , @khchen wrote: > But there is some issue if we set the default rv32 march as `rv32gc`. > Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu > toolchain, >

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. Herald added a subscriber: sameer.abuasal. @lenary You patch is very useful to look up the default march, thanks! But there is some issue if we set the default rv32 march as `rv32gc`. Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > khchen wrote: > > lenary wrote: > > > I think this line is the issue: where someone doesn't specify `-march`, >

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Ok, found a path forward for this patch. Notes inline: Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else khchen wrote: > lenary wrote: > > I think this line is the issue: where

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > I think this line is the issue: where someone doesn't specify `-march`,

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary requested changes to this revision. lenary added a comment. This revision now requires changes to proceed. Sorry for approving, and then requesting changes. I've been investigating issues with this patch. When I try to use `-print-multi-lib` (a clang option that is very

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I finally got my system well setup enough to check this patch with my risc-v toolchains. It looks good, I'm happy for this to land. There's no requirement to support MULTILIB_REUSE yet. It

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1521 + {"rv32i", "ilp32"},{"rv32im", "ilp32"}, {"rv32iac", "ilp32"}, + {"rv32imac", "ilp32"}, {"rv32imafc", "ilp32f"}, {"rv64i", "lp64"}, +

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 225068. khchen edited the summary of this revision. khchen added a comment. @lenary Sorry, I don't have the plan to support `MULTILIB_REUSE` now. But if it's necessary to support it, I can do it later. CHANGES SINCE LAST ACTION

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Please can you rebase these changes? Something has changed in RISCVToolchain.cpp and they are failing to build. Q: Is there a plan to support multilib aliases (`MULTILIB_REUSE`)? I'm happy for this to be in a follow-up patch, would just like to know the plan.

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 +{M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); kito-cheng

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220686. khchen marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 +{M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); It could be "riscv32-unknown-elf" other than