[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. In D68997#2377641 , @stella.stamenova wrote: > This change broke the windows lldb bot: > > http://lab.llvm.org:8011/#/builders/83/builds/570 > > Can you please fix this or revert? Looking at this now. Repository: rG LLVM Githu

[PATCH] D68997: Allow searching for prebuilt implicit modules.

stella.stamenova added a comment. This change broke the windows lldb bot: http://lab.llvm.org:8011/#/builders/83/builds/570 Can you please fix this or revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D6899

[PATCH] D68997: Allow searching for prebuilt implicit modules.

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3382 } +if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) + CmdArgs.push_back("-fprebuilt-implicit-modules"); You need to use a fno_ flag as 2nd param if

[PATCH] D68997: Allow searching for prebuilt implicit modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e108cd86e7: Allow searching for prebuilt implicit modules. (authored by arames). Changed prior to commit: https://reviews.llvm.org/D68997?vs=300

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames marked an inline comment as done. arames added a comment. Fixed the trailing whitespace. I also just got commit rights, so I will commit it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 __

[PATCH] D68997: Allow searching for prebuilt implicit modules.

dexonsmith added a comment. @arames, I see you've had a number of commits. I suggest you request commit access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Comment at: clang/docs/Modules.rst:358 + +This way, a single directory containing multiple variant

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 300780. arames added a comment. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td

[PATCH] D68997: Allow searching for prebuilt implicit modules.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:187 + /// The hash used for module cache paths. + std::string ModuleHash; + In the previous version of this patch, this value was derived from the stem of `ModuleCachePath`. Howev

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 282336. arames added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td cla

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 282335. arames marked an inline comment as done. arames added a comment. Addressed review comments. - Fixed typos in the doc. - Added doc about module compatibility. - Cleaned and tested commands in the doc. - Reworked module hash code to not require `-fmodule

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/docs/Modules.rst:295 + +A trick to prebuilt required modules in one command is to generate implicit modules using the ``-fdisable-module-hash`` option. + Bigcheese wrote: >

[PATCH] D68997: Allow searching for prebuilt implicit modules.

Bigcheese added inline comments. Comment at: clang/docs/Modules.rst:231 + prebuilt modules paths (specified via ``-fprebuilt-module-path``), we will + look for a matching implicit modules in the prebuilt modules paths. + Comment at: clang/do

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 281602. arames added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td clang/i

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 279263. arames added a comment. Herald added a subscriber: dang. Rebase on top-of-tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 264096. arames added a comment. Rebase on top of tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Optio

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Still looking for someone to take a look. Happy to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-c

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 228267. arames added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td clang/i

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames edited the summary of this revision. arames added reviewers: bruno, rsmith. Herald added a subscriber: dexonsmith. The behavior is controlled by the `-fprebuilt-implicit-modules` option, and