SouraVX added a comment.
Hi @aprantl, could you please review these changes, while I rework on the other
one. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
___
cfe-commits mailing list
cfe
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/docs/SourceLevelDebugging.rst:998
+
+There are couple of new DWARF attributes defined to enhance debugging of C++
programs. LLVM can generate (or omit
SouraVX added a comment.
Hi Adrian, Thanks for taking out time for reviewing this. I've again updated
doc.
Currently we're in process of getting commit access, discussion with Tom in
progress
So, could you please commit these changes.
Thank you so much!
CHANGES SINCE LAST ACTION
https://rev
SouraVX updated this revision to Diff 226867.
SouraVX added a comment.
Updated doc.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-deleted.cpp
llvm/docs/SourceLevel
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf919be336583: [DWARF5] Added support for deleted C++ special
member functions. (authored by aprantl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new
SouraVX created this revision.
SouraVX added reviewers: probinson, dblaikie, aprantl.
SouraVX added a project: debug-info.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
SouraVX marked an inline comment as done.
SouraVX added inline comments.
=
SouraVX marked an inline comment as done.
SouraVX added inline comments.
Comment at: llvm/test/DebugInfo/X86/DW_AT_deleted.ll:68
+
+attributes #0 = { noinline nounwind optnone uwtable }
+attributes #1 = { nounwind readnone speculatable willreturn }
Removed all st
SouraVX updated this revision to Diff 225749.
SouraVX added a comment.
Corrected typo in test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-deleted.cpp
llvm/
aprantl added a comment.
Can you add the new flag to either SourceLevelDebugging.rst or LangRef.rst
(wherever it fits better)?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
___
cfe-commits mailing
aprantl added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610
+ // DWARF5 we're checking deleted C++ special member functions
+ // [Ctors,Dtors, Copy/Move]
We spell this a `DWARF v5` throughout the sources, makes it easier to grep for.
Th
SouraVX updated this revision to Diff 225926.
SouraVX added a comment.
Addressed comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-deleted.cpp
llvm/include/l
SouraVX marked 4 inline comments as done.
SouraVX added a comment.
Thanks Adrian for reviewing this! I've addressed your comments. Please have a
look.
Working on the adding documentation part.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1624
+ case Decl::CXXMethod:
+if
SouraVX updated this revision to Diff 226004.
SouraVX added a comment.
Updated the documentation for this new flag.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69215/new/
https://reviews.llvm.org/D69215
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-del
13 matches
Mail list logo
