[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. > I think this would likely make everything much more complicated, but perhaps > we should think about this for the configuration at least now so we future > proof ourselves. What you've outlined looks good to me. Of course we will be happy to contribute, given there will

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. > But I don't know if this can be (easily) supported in a .clang-format file, > since the style options are defined as (static) enums. I realize my proposal > might be out of the scope of this patch, but I wanted to get some opinions > from the community. just t

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. In D69764#1775842 , @MyDeveloperDay wrote: > In D69764#1775835 , @ilya wrote: > > > In D69764#1732235 , @aaron.ballman > > wrote: > > > > > I like the

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1775835 , @ilya wrote: > In D69764#1732235 , @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > > terminology -- that's

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. In D69764#1732235 , @aaron.ballman wrote: > I like the functionality, but am slightly opposed to using "east/west" > terminology -- that's not a ubiquitous phrase and it takes a bit of thinking > before it makes sense. I think "lef

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

aaron.ballman added a comment. If there's strong sentiment to only go with East/West, I'll not block the feature to argue about the names further. That said, I still think East/West is a kitschy phrasing and I've seen multiple people get temporarily confused by it (while wearing the bracelets,

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. In D69764#1768420 , @MyDeveloperDay wrote: > As a consensus how about I drop Before/After and Keep Left/Right and > West/East const support? (as no one is asking for Before/After?) can we > handle having 2 options to aid langu

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. As a consensus how about I drop Before/After and Keep Left/Right and West/East const support? (as no one is asking for Before/After?) can we handle having 2 options to aid language issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https:/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. aaron.ballman wrote: > MyDeveloperDay wr

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

aaron.ballman added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. MyDeveloperDay wrote: > klimek wrote: > > Personally, I'm somewhat against having 3 differ

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. klimek wrote: > Personally, I'm somewhat

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

klimek added a comment. I'm not generally opposed to this, given that a) clang-format already changes code; I think by now we're not fixing double semicolon mainly for workflow reasons, would be fine to add b) the implementation is very self contained Comment at: clang/docs/Cl

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 230124. MyDeveloperDay added a comment. -update with missing files -clang-format test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Relea

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. -

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

JonasToth added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. Drive-By question: https://reviews.llvm.or

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 229996. MyDeveloperDay added a comment. - Rebase - Add Release note - Remove repeated lines cause by patch creation artefact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFo

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228843. MyDeveloperDay added a comment. Make the patch file correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Form

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228842. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Fix an issue with foo() const override/final Be more specific about this being turned off in all the base styles CHANGES SINCE LAST

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. NOTE: Add foo() const override and foo() const override LLVM_READONLY test examples as these currently fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-c

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. I definitely agree with the default being "do nothing", its not just google style, nearly everyone is using a style which is derived from one of these base styles, that said turning on a const style by default would IMHO be a mistake, the level of churn could be

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. In D69764#1740594 , @MyDeveloperDay wrote: > In D69764#1740582 , @sammccall wrote: > > > (Sorry for arriving at this late) > > > > At a strategic level, I have some concerns here: the fac

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1740582 , @sammccall wrote: > (Sorry for arriving at this late) > > At a strategic level, I have some concerns here: the fact that clang-format > generally doesn't touch the token sequence isn't an accident. > e.

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. (Sorry for arriving at this late) At a strategic level, I have some concerns here: the fact that clang-format generally doesn't touch the token sequence isn't an accident. e.g. formatting `int x;;` will insert a newline rather than deleting the redundant semicolon. Li

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

Meinersbur added a comment. In D69764#1732232 , @MyDeveloperDay wrote: > @pollydev too (a previously clang-format clean directory) will generate > changes running `clang-format --const-style=west -i -n *.cpp` > > ScopBuilder.cpp:74:9: warning: code sho

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 227708. MyDeveloperDay retitled this revision from "[clang-format] Add East Const / West Const fixer" to "[clang-format] Add Left/Right Const (East/West , Before/After) fixer capability". MyDeveloperDay edited the summary of this revision. MyDeveloperD