[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk abandoned this revision. rnk added a comment. I think this isn't necessary. I think I got most of the value of this in rG60573ae6fe509b618dc6a2c5c55d921bccd77608 , and we don't need two AttrBase.h / Attr.h headers in the l

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > rn

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the follow-up plan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70627/new/ https://reviews.llvm.org/D70627

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// rnk wrote: > aaron.ballman wrote: > > rnk wrote: > > > aaron.ballman wrote: > > > > This should

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > Th

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// rnk wrote: > aaron.ballman wrote: > > This should read `Attrs.h` instead, but I find the naming

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added a comment. Thanks! Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > This should read `Attrs.h` instead, but

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added a comment. Basically LGTM but I am hoping we can get a better name than `Attr.h` and `Attrs.h`. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// This should r

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk created this revision. rnk added a reviewer: aaron.ballman. Herald added subscribers: arphaman, mgrang, kosarev, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Many AST headers require Attr to be complete, but do not need the complete table generated list of at