[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4c70dd3ec6: [clang-tidy] Add spuriously-wake-up-functions check (authored by abelkocsis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 251829. abelkocsis added a comment. Format fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, do you need me to commit on your behalf? Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.c:165 +int main() { return 0; } \ No newline at end of file

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 245113. abelkocsis added a comment. Test cases adding, checker modifying to pass new cases. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a test coverage request. Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.c:26-30 + if (list_c.next ==

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 244098. abelkocsis added a comment. docs/list.rst update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

steakhal added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:300-301 + `cert-con36-c `_, `bugprone-spuriously-wake-up-functions `_, "Yes" + `cert-con54-cpp `_, `bugprone-spuriously-wake-up-functions `_, "Yes" `cert-dcl03-c `_,

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 243779. abelkocsis added a comment. Checker update to analyse language, separated checks for C and C++. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SpuriouslyWakeUpFunctionsCheck.cpp:60 + .bind("wait")); + Finder->addMatcher( + ifStmt(anyOf( Sorry for not noticing this earlier, but I think you can make two

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235469. abelkocsis marked an inline comment as done. abelkocsis added a comment. Checker fixes, updates test file adding test cases for `doWhile` and `for` statements, test headers deleted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis marked 11 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.cpp:2 +// RUN: %check_clang_tidy %s bugprone-spuriously-wake-up-functions %t -- -- -I

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SpuriouslyWakeUpFunctionsCheck.cpp:22 + auto hasUniqueLock = hasDescendant(declRefExpr(hasDeclaration( + varDecl(hasType(asString("std::unique_lock")); + These

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:75 `bugprone-sizeof-expression `_, , "high" + `bugprone-spuriously-wake-up-functions `_, , "" `bugprone-string-constructor `_, "Yes", "high" Could

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235232. abelkocsis added a comment. `docs/clang-tidy/checks/lsit.rst` update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

whisperity added a comment. The `checks.rst` has recently been updated to show "normal" (main entry) checks and "aliases" in different tables in D36051 . Please register the alias-ness accordingly. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235212. abelkocsis added a comment. Adding matcher for `cnd_timedwait` and test cases. Small fix in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-spuriously-wake-up-functions.rst:4 +bugprone-spuriously-wake-up-functions += + Please make length same as in title. Repository:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235180. abelkocsis added a comment. Checker is moved to bugprone section, tests added. C checker is improved, and documentations are synchronised. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:45-46 "misc-redundant-expression"); +CheckFactories.registerCheck( +"misc-spuriously-wake-up-functions");

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

Eugene.Zelenko added a comment. I don't think that //misc// module should be used when checks belong to //cert// Comment at: clang-tools-extra/clang-tidy/misc/SpuriouslyWakeUpFunctionsCheck.cpp:77 +const MatchFinder::MatchResult ) { + + const auto *MatchedWait =