[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 247615. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein added a comment. > Also, the llvm::Twine fails too, many of the failures are related to the > forward declarations (I think the problem is that they are treated > differently from the original symbol and are not being renamed at all in the > corresponding files, but that's just my

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. In D71110#1871896 , @hokein wrote: > Thanks for the feedback! > > Yeah, currently template classes are not supported in cross-file rename, see >

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein added a comment. Thanks for the feedback! Yeah, currently template classes are not supported in cross-file rename, see https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/refactor/Rename.cpp#L187. So `llvm::Optional` and `llvm::Optional` should fail to rename, but

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. Renaming `llvm::Optional` also fails (clangd-rename says the symbol is not of a supported kind even though it's a class). Renaming `llvm::None` is also not working: there seem to be many problems but a lot of them are connected with function's argument default values

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. Thanks! Now I can build it. I was able to get some rename failures through this tool, though :( I had to disable the check for number of affected files first, but then this seems to be problematic: llvm/include/llvm/ADT/ArrayRef.h llvm::ArrayRef clangd

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 243768. hokein marked 3 inline comments as done. hokein added a comment. - rebase to master - fix the breakage of the rename tool - add more symbol to the tests - some tweaks on the python script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein added a comment. sorry for the delay, I just saw the comment today. In D71110#1799960 , @kbobyrev wrote: > For some reason, running this patch on a recent version of the source tree > fails. The AST parsing fails with fatal diagnostics, but I

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. For some reason, running this patch on a recent version of the source tree fails. The AST parsing fails with fatal diagnostics, but I can't understand why: E[15:14:33.084] source file unknown type name 'PathRef' is illformed: 1 E[15:15:02.831] source file unknown

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232554. hokein added a comment. Fix empty lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232553. hokein added a comment. add more symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This is a tool that helps us to evaluate the rename results, we may not submit this tool to the code repository, but it has