Re: [PATCH] D71545: [clangd] Improve hover for auto on template instantiations

Ok, sorry for getting the wrong end of the stick re the history. Arguments vs parameters - are we sure this is a distinction worth surfacing to users/uis? I guess modeling both using the same struct is awkward. On Wed, Dec 18, 2019, 10:57 AM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1209 // FIXME: Print template instantiation parameters. -HI.Name = "initializer_list"; +HI.Name = "initial

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1209 // FIXME: Print template instantiation parameters. -HI.Name = "initializer_list"; +HI.Name = "initializer_list"; HI.Kind = index::

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet abandoned this revision. kadircet marked an inline comment as done. kadircet added a comment. integrated into D71543 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71545/new/ https://reviews.llvm.org/D71545

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:556 +// FIXME: Drop default arguments. +HI.Name = "Foo"; +HI.Kind = index::SymbolKind::Class; -

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:556 +// FIXME: Drop default arguments. +HI.Name = "Foo"; +HI.Kind = index::SymbolKind::Class; NIT: Maybe remove default argument

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60957 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D71544: [clangd] Improve printing of lambda names. Follow-up to D71543