[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2eb220edd5: [ThinLTO] Summarize vcall_visibility metadata (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 239412. tejohnson added a comment. Address comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files:

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:762 +bool ReadOnly, bool WriteOnly, bool Constant, +GlobalObject::VCallVisibility Vis = GlobalObject::VCallVisibilityPublic) : MaybeReadOnly(ReadOnly),

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 238565. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/test/CodeGenCXX/vcall-visibility-metadata.cpp

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson added a comment. In D71911#1823497 , @evgeny777 wrote: > I think this has to be rebased - I see multiple failures when trying to apply I'll rebase it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added a comment. I think this has to be rebased - I see multiple failures when trying to apply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 ___

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 235510. tejohnson added a comment. Attempt to fix patch to not include parent revision changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files:

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 235509. tejohnson added a comment. Implement suggested name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:794 + } + GlobalObject::VCallVisibility vCallVisibility() const { +return (GlobalObject::VCallVisibility)VarFlags.VCallVisibility; getVCallVisibility() ? Repository:

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777, steven_wu. Herald added subscribers: arphaman, dexonsmith, hiraditya, inglorion, Prazek, mehdi_amini. Herald added projects: clang, LLVM. Second patch in series to support Safe Whole Program Devirtualization Enablement,