[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Herald added a reviewer: MaskRay. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

pcc added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > pcc wrote: > >

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

pcc added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777 wrote:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson added a comment. In D71913#1837872 , @tejohnson wrote: > FYI I reverted this in rG90e630a95ecc > due to > a cfi test failure in a windows sanitizer bot. Not sure what is

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson added a comment. FYI I reverted this in rG90e630a95ecc due to a cfi test failure in a windows sanitizer bot. Not sure what is happening, I'll need to try to debug it somehow tomorrow. Repository: rG LLVM Github

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

This revision was automatically updated to reflect the committed changes. Closed by commit rG59733525d37c: [LTO/WPD] Enable aggressive WPD under LTO option (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239890. tejohnson added a comment. Implement suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added a comment. Looks good so far. See remaining comment in D71907 Comment at: clang/lib/CodeGen/CGVTables.cpp:1050 - if (getCodeGenOpts().LTOVisibilityPublicStd) { -const DeclContext *DC = RD; -while (1) { - auto

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239646. tejohnson added a comment. Address remaining comment by blocking type test insertion for public std visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 5 inline comments as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239428. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments and rebase. Also apply modified change to ItaniumCXXABI.cpp and a change to an associated test (cfi-mfcall.cpp) here as discussed in child revision D71907

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239214. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 4 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt -wholeprogramdevirt-summary-action=import

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 238569. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGClass.cpp

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 2 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added a comment. Thanks, I'm still in process of testing (now fixing issue which however is most likely related to devirtualization itself, not to this patch). Meanwhile some of my comments below. Comment at:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 9 inline comments as done. tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:559 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) +MPM.add(createLowerTypeTestsPass(/*ExportSummary=*/nullptr, +

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 238048. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:559 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) +MPM.add(createLowerTypeTestsPass(/*ExportSummary=*/nullptr, + /*ImportSummary=*/nullptr,

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777, steven_wu. Herald added subscribers: dang, dexonsmith, MaskRay, hiraditya, arichardson, inglorion, Prazek, emaste. Herald added a reviewer: espindola. Herald added projects: clang, LLVM. Third part in series to support