[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2023-01-12 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: Naghasan, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. D72362 has landed. I'd advise to see if any of the testcases here aren't being reported by that check, and filing a bugs for them. Other than that, abandon? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-11 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies added a comment. In D72239#1815583 , @JonasToth wrote: > The other recursion check seems more sophisticated. What is your take on it? > Would you consider it better as well, what is your opinion on it? I agree, I would go with the other check

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-11 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. The other recursion check seems more sophisticated. What is your take on it? Would you consider it better as well, what is your opinion on it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72239/new/

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-07 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D72239#1805281 , @lebedev.ri wrote: > I was just going to look into this kind of check. > This can be implemented without recursion in the check itself. > Let me write it and post my variant. D72362

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-05 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I was just going to look into this kind of check. This can be implemented without recursion in the check itself. Let me write it and post my variant. Repository: rCTE

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/opencl/RecursionNotSupportedCheck.cpp:28 +void RecursionNotSupportedCheck::check(const

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-01-05 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies created this revision. ffrankies added reviewers: aaron.ballman, alexfh, hokein. ffrankies added projects: clang, clang-tools-extra, LLVM. Herald added subscribers: mgehre, arphaman, xazax.hun, Anastasia, yaxunl, mgorny. This lint check is part of the FLOCL (FPGA Linters for OpenCL)