[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies added a comment. @aaron.ballman @njames93 thanks for testing this out, the feedback, and the commit! Could you also take a look at D72235 unroll loops check ? It's been updated and is ready for review. CHANGES SINCE LAST ACTION

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

njames93 added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's something else > you'd like me to try. Thanks!

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman closed this revision. aaron.ballman added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 312658. ffrankies marked an inline comment as done. ffrankies added a comment. @aaron.ballman hmm, that is strange. I've rebased the patch and updated the diff, let me know if this one doesn't work either or there's something else you'd like me to try.

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman added a comment. In D72241#2449426 , @ffrankies wrote: > @aaron.ballman Thank you! If there are no further comments, could you please > commit this on my behalf? My GitHub username is ffrankies > . I'd be

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies marked 4 inline comments as done. ffrankies added a comment. @aaron.ballman Thank you! If there are no further comments, could you please commit this on my behalf? My GitHub username is ffrankies . Comment at:

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72241/new/ https://reviews.llvm.org/D72241 ___ cfe-commits mailing list

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 309565. ffrankies added a comment. Implemented changes requested by @aaron.ballman - using `hasAnyName()` instead of multiple `hasName()` calls in the matcher - switched to a combination of `hasAttr<>()` and `getAttr<>()` to remove need for casting and

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:34 + hasName("barrier"), + hasName("work_group_barrier") +

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 295698. ffrankies removed a project: clang. ffrankies added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Rebased code and fixed merge conflicts with D66564 - Added

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 254304. ffrankies added a comment. - Updated underlying repo to https://github.com/llvm/llvm-project - Removed braces from one-line if-statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72241/new/ https://reviews.llvm.org/D72241 Files:

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 243717. ffrankies marked 3 inline comments as done. ffrankies added a comment. Implemented requested changes by @Eugene.Zelenko - Changed `auto` to `const auto *` - Changed `if(IsNDRange == true)` to `if(IsNDRange)` - Highlighted 1600 with single

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:51 +if (Attribute->getKind() ==

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies created this revision. ffrankies added reviewers: aaron.ballman, alexfh, hokein, Eugene.Zelenko. ffrankies added projects: clang-tools-extra, clang. Herald added subscribers: mgehre, jfb, arphaman, xazax.hun, Anastasia, mgorny. This lint check is a part of the FLOCL (FPGA Linters for