[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-11 Thread Jonas Toth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4c48ea68e491: [ASTMatchers] extract public matchers from const-analysis into own patch (authored by JonasToth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-11 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 237514. JonasToth added a comment. - remove merge conflict markers in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-11 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 237511. JonasToth added a comment. - fix compilation error, missing getType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-11 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 237510. JonasToth marked 3 inline comments as done. JonasToth added a comment. - add test for K functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a testing request. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4243 + if (FProto) { +QualType ParamType =

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4243 + if (FProto) { +QualType ParamType = FProto->getParamType(ParamIndex); +if (ParamMatcher.matches(ParamType, Finder,

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 237338. JonasToth added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4207-4208 + if (const auto *Call = dyn_cast()) { +if (const Decl *Callee = Call->getCalleeDecl()) { + if (const auto *Value = dyn_cast(Callee)) { +QualType QT =

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth created this revision. JonasToth added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. JonasToth added a child revision: D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness. The analysis for