ianlevesque updated this revision to Diff 238600.
ianlevesque added a comment.
fix clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72873/new/
https://reviews.llvm.org/D72873
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/
ianlevesque created this revision.
ianlevesque added a reviewer: dberris.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
ianlevesque updated this revision to Diff 238600.
ianlevesque added a comment.
fix clang-format
XRay allows tuning by minimum function size, but also a
ianlevesque marked an inline comment as done.
ianlevesque added inline comments.
Comment at: clang/test/CodeGen/xray-ignore-loops.cpp:5
+ return 1;
+}
+
hiraditya wrote:
> I think we need one more test case of a function having a loop.
I'm not opposed but the lo
hiraditya added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:821
llvm::itostr(CGM.getCodeGenOpts().XRayInstructionThreshold));
+ if (CGM.getCodeGenOpts().XRayIgnoreLoops) {
+Fn->addFnAttr("xray-ignore-loops");
we ca
hiraditya accepted this revision.
hiraditya added a comment.
This revision is now accepted and ready to land.
The test case is in another patch so LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72873/new/
https://reviews.llvm.org/D72873
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1d62be244108: [clang][xray] Add -fxray-ignore-loops option
(authored by ianlevesque, committed by smeenai).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D728
