[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

This revision was automatically updated to reflect the committed changes. Closed by commit rG4662f6e1c778: [test] Avoid loop-unroll.c test getting confused by fadd in git revision (authored by russell.gallop). Changed prior to commit: https://reviews.llvm.org/D73162?vs=239808&id=239812#toc Rep

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop added a comment. In D73162#1834379 , @asbirlea wrote: > Oh, wow! Might I ask you add the same for fmul? We may get a revision like > that next time :). > Thank you! fmul shouldn't have the same problem as git hashes are only hex characte

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop updated this revision to Diff 239808. russell.gallop added a comment. Update to check for start of metadata. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ https://reviews.llvm.org/D73162 Files: clang/test/CodeGen/loop-unroll.c Index: clang/test/CodeGen/loo

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

asbirlea added a comment. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ https://reviews.llvm.org/D73162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

fhahn added a comment. I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like `CHECK : !0 =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ htt

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :). Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop created this revision. russell.gallop added a reviewer: asbirlea. Herald added a subscriber: zzheng. Herald added a project: clang. Saw this test failing as it was matching fadd in a (local) git revision: F:\git\llvm-project\clang\test\CodeGen\loop-unroll.c:38:30: error: CHECK-D